search

eikonomega / django-notification-system

Want to send notifications from your Django app? Start here.
MIT License
14 stars 9 forks source link

Remove unique constrain from 'extra' field #33

Closed ghaffari-nia closed 2 years ago

ghaffari-nia commented 3 years ago

There is a problem when using django-notification-system with MySQL, the problem is MySQL cannot have constraint on JSON fields. Removing extra from unique_together solves the problem.

Note that creating another migration from changes is not an option because the first migration already fails on MySQL.

eikonomega commented 2 years ago

Hi @ghaffari-nia thanks for submitting this.

It doesn't seem to me that this is a feature that we would want to implement. From my perspective - having the unique constraint on the extra field is pretty important as it would prevent a user from accidentally being scheduled to receive two of the same notifications.

Also - I'm afraid that messing with already existent migrations would cause problems for others already using the library.