search

eileenmcnaughton / dompdf-fonts

Other
1 stars 1 forks source link

Fixups to README.md #1

Closed demeritcowboy closed 2 years ago

eileenmcnaughton commented 2 years ago

thanks @demeritcowboy - I see $b=1 survived...

demeritcowboy commented 2 years ago

I tried writing a unit test to show when it fails but it seems $b really is always 1. Maybe revisit for php 9 where numbers are deprecated. (grin)

Seriously - the format of that file changes slightly in dompdf 1.1 although it will still work as-is, but could revisit then. Or not.

eileenmcnaughton commented 2 years ago

@demeritcowboy OK - probably easy enough to update this extension when we need to - ideally it probably would do CJK as well but I didn't get to that (& it wasn't my need)