search

eileenmcnaughton / nz.co.fuzion.civixero

Synchronisation between CiviCRM & Xero
7 stars 14 forks source link

Remove duplicate functions to get/set settings #114

Closed mattwire closed 1 year ago

mattwire commented 1 year ago

Multiple functions to retrieve settings that work slightly differently. One of the causes of occasional bugs with transient invalid access tokens - that fail and then work next time you run.

eileenmcnaughton commented 1 year ago

I like the approach of havving a settings object for the extension - the PR is conflicted now....

mattwire commented 1 year ago

Rebased

eileenmcnaughton commented 1 year ago

I've scanned the code & it looks good. I haven't tested it & at this stage am relying on your testing