search

eileenmcnaughton / nz.co.fuzion.civixero

Synchronisation between CiviCRM & Xero
7 stars 14 forks source link

Fix fatal error on invoice push job #133

Closed jitendrapurohit closed 2 months ago

jitendrapurohit commented 2 months ago

Regression due to https://github.com/eileenmcnaughton/nz.co.fuzion.civixero/commit/4d580a01f36fee1fe33c72e8b971f94b106a642d?

Got error 'PHP message: PHP Fatal error: Declaration of CRM_Civixero_BankTransaction::getNotUpdateCandidateResponses() must be compatible with CRM_Civixero_Invoice::getNotUpdateCandidateResponses(): array in /sites/default/civicrm/extensions/nz.co.fuzion.civixero/CRM/Civixero/BankTransaction.php on line 138PHP message: PHP Stack trace:PHP message: PHP

Stopped cron from running and no invoice being pushed to xero.

PR also removes an undefined variable $nvpreq from packages/Xero/Xero.php.