Introduced parameter type hinting of mapToAccounts causes an error

eileenmcnaughton / nz.co.fuzion.civixero

Synchronisation between CiviCRM & Xero

7 stars 14 forks source link

Introduced parameter type hinting of mapToAccounts causes an error #152

Closed glen-stanbridge-brightminded closed 2 months ago

glen-stanbridge-brightminded commented 2 months ago

The recently introduced parameter type hint in mapToAccounts causes an error when $accountsContactID is assigned as null

$accountsContactID = !empty($record['accounts_contact_id']) ? $record['accounts_contact_id'] : NULL; $accountsContact = $this->mapToAccounts($contact, $accountsContactID);

protected function mapToAccounts(array $contact, string $accountsContactID)