eileenmcnaughton / nz.co.fuzion.csvimport

Import to API using csv GUI
GNU Affero General Public License v3.0
8 stars 27 forks source link

pass-by-ref function argument just changed in core master #51

Closed demeritcowboy closed 2 years ago

demeritcowboy commented 2 years ago

This just changed in core master a few days ago. Now gives Declaration of CRM_Csvimport_Import_Form_MapField::defaultFromHeader($header, &$patterns) should be compatible with CRM_Import_Form_MapField::defaultFromHeader($header, $patterns)

eileenmcnaughton commented 2 years ago

I can probably remove this function & rely on the parent?

demeritcowboy commented 2 years ago

Oh. I don't know. The parent seems to do other stuff. This just came up while doing something else with php 8. Because of class-scanning when you send a message template email it tries to load almost every file, and then hits this.

eileenmcnaughton commented 2 years ago

OK - well this will do for now

demeritcowboy commented 2 years ago

Thanks