search

eileenmcnaughton / nz.co.fuzion.extendedreport

Extended Reports for CiviCRM
GNU Affero General Public License v3.0
20 stars 57 forks source link

Regression: PR #529 causes Afform tabs to show up in "Manage Events". #538

Closed MegaphoneJon closed 1 year ago

MegaphoneJon commented 1 year ago

@colemanw @eileenmcnaughton https://github.com/eileenmcnaughton/nz.co.fuzion.extendedreport/pull/529 introduces an interesting regression. This is on 5.57.1.

"Summary and Tab: Events by type" is an Afform on this site which adds a new tab to contact records (with an SK query).

With PR #529 applied, it appears in my "Manage Events" screen as an event.

My "Manage Events" page without PR #529:

Selection_1747

My "Manage Events" page with PR #529: Selection_1746

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

eileenmcnaughton commented 1 year ago

Did the commit I just merged fix this?

colemanw commented 1 year ago

@eileenmcnaughton yea #554 was to fix this