search

eileenmcnaughton / nz.co.fuzion.omnipaymultiprocessor

Omnipay Multi Processor Payment Processor For CiviCRM
Other
14 stars 44 forks source link

Form processor improvement #260

Closed jaapjansma closed 11 months ago

jaapjansma commented 11 months ago

This PR contains an improvement to the form processor action for creating an online payment.

Instead of asking for the currency and the amount it now asks for the Contribution ID and takes all the necessary data from the contribution.

magnolia61 commented 11 months ago

Not sure if I'm reading this right, but should not the amount be the remaining amount instead of the contribution total amount? (to account for partial payments?) - maybe I am totally wrong here though

eileenmcnaughton commented 11 months ago

@magnolia61 yes - if the point of this PR is to pay the balance then balance_amount is the correct apiv4 key

magnolia61 commented 11 months ago

I think using balance_amount in this PR would make this compatible with partial payments, and in case of a fully required payment it also would work. If it's through the formprocessor or another way, I am looking for ways to emerge to do partial front-end payments, since that is currently not possible in CiviCRM.

jaapjansma commented 11 months ago

Thanks for the pointer to balance_amount. I did not know about that field. I have added a follow up PR #262