search

eileenmcnaughton / nz.co.fuzion.omnipaymultiprocessor

Omnipay Multi Processor Payment Processor For CiviCRM
Other
13 stars 44 forks source link

Fix a problem with php 8 and civicrm 5.67.1 #261

Open jaapjansma opened 10 months ago

jaapjansma commented 10 months ago

When I installed this in our demo environment I discovered a compatibility issue with php 8 and civicrm 5.67.1 and Drupal 10.

Not sure whether this breaks other compatibility, such as Drupal 7, or wordpress or older versions of CiviCRM.

eileenmcnaughton commented 10 months ago

Thanks @jaapjansma - these files are pulled in by composer so I'm guessing we need to change the version of symfony? There is a big-picture issue around how extensions with composer packages install - here I have committed them which is easy for some frameworks but tricky for others. So consistent with that we would update any package within the extension by doing a composer update & committing the results. I'm just wonder what the various versions of symfony that are involved are.

I might raise over on dev that WMF uses the composer merge plugin package (& then does not commit any vendor directories to our git) - I don't know if that package could be used more broadly

jaapjansma commented 10 months ago

@eileenmcnaughton I am not very familiar with composer and extension within a framework. But the composer merge plugin sounds reasonable. Maybe @totten or @mattwire have any thoughts that.

stesi561 commented 6 months ago

This PR is now out of date but this issue is related: https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/259

stesi561 commented 6 months ago

@eileenmcnaughton is it worth updating this PR to update symfony/http-foundation or is there ongoing work here to address the underlying issue? I think currently for D10 we'd need symfony/http-foundation 6.4.x but I'm keen to explore options for composer merge plugin package.

jaapjansma commented 1 month ago

@eileenmcnaughton I have updated this PR so it can be merged.

nganivet commented 4 days ago

@eileenmcnaughton Patch confirmed working on D10 / 5.75 / latest Omnipay release

eileenmcnaughton commented 4 days ago

thanks @nganivet - but we do need to figure out how to do this via composer rather than hack the package (we just do the composer update & commit the updated files currently)

nganivet commented 4 days ago

Thanks for the quick response. Would it be possible to do this with composer patches? I recently encountered https://civicrm.stackexchange.com/questions/47989/db-error-unknown-database-when-creating-a-civimail-mailing and this seems to imply we can apply patches to dependencies. Could we roll this patch into CiviCRM core?