search

eileenmcnaughton / org.wikimedia.geocoder

Geocoder for CiviCRM
Other
6 stars 17 forks source link

Set optional parameters of http_build_query #28

Closed sebalis closed 3 years ago

sebalis commented 3 years ago

If arg_separator is not set, the default value comes from arg_separator.output which is not always set to the value we need here, which is '&'. On Ubuntu the default is '&'. There is no need to adhere to any system defaults here because we know exactly in which context the URLs we build are used: for a backend request that is executed soon in the same PHP handler. The same parameters are used in the MapQuest provider.

eileenmcnaughton commented 3 years ago

@sebalis - Nominatim is a package that we include from https://github.com/geocoder-php/nominatim-provider - can you try submitting your fix to the upstream repo so we can update using composer?

sebalis commented 3 years ago

Sure, I’ll see what I can do.

sebalis commented 3 years ago

Just noticed that in my extended descripion the Ubuntu setting got mangled – the default there is &‌amp; and I hope it makes more sense now :-)

sebalis commented 3 years ago

A bot there refers me to http://github.com/geocoder-php/Geocoder – is this going to be an endless cycle? :-)

sebalis commented 3 years ago

Now at https://github.com/geocoder-php/Geocoder/pull/1131 waiting for workflows to finish.

sebalis commented 3 years ago

Do you need/want me to close this PR now, @eileenmcnaughton​?

eileenmcnaughton commented 3 years ago

@sebalis yeah maybe close this & open an issue to composer update once they merge it?

sebalis commented 3 years ago

Of course, I’ll let you know. Thanks for now.