search

eileenmcnaughton / org.wikimedia.geocoder

Geocoder for CiviCRM
Other
6 stars 17 forks source link

Implement Geocoding by Postal Codes for Germany #36

Closed Detsieber closed 11 months ago

Detsieber commented 1 year ago

This solution is similar to the implementation of OK postcodes.

Detsieber commented 1 year ago

@eileenmcnaughton : This commit is active for more than a year in a heavily used production environment (however, with Geocoder 1.7), and works well.

However, there are still a few issues: 1) It ships together with the complete dataset of German postcodes. AFAIK there are no license issues for that - but if you would prefer to better load the data from an external source, this would still have to be implemented. (I would think it would be better to ship the data with the extension, or at least provide an easy way to load the data via the UI) 2) no unit tests for German postcodes 2) Update of Readme is missing

Please let me know what you need for merging this!

eileenmcnaughton commented 11 months ago

This was replaced by #38