search

eileenmcnaughton / org.wikimedia.geocoder

Geocoder for CiviCRM
Other
6 stars 17 forks source link

Add database upgrade step for 1.9 to update the URL for Open Street Map end point #39

Closed agileware-justin closed 1 year ago

agileware-justin commented 1 year ago

Add database upgrade step for 1.9 to update the URL for Open Street Map end point

Ping @eileenmcnaughton

Agileware Ref: CIVICRM-2159

eileenmcnaughton commented 1 year ago

Thanks @agileware-justin

sebalis commented 1 year ago

Thank you, @agileware-justin! See my two (minor) comments.

eileenmcnaughton commented 1 year ago

Per ping from @agileware-justin I'm gonna tag 1.10 - the minor comments are improvements - but it's Friday so lets wrap this up this week & we can improve or not later

sebalis commented 1 year ago

Yes, fine with me, and thanks to @agileware-justin for taking care of the upgrade step. And for giving me the opportunity to finally understand how upgrade steps work :-) This will help me to submit more complete PRs in the future.

eileenmcnaughton commented 1 year ago

@sebalis sounds like a win. The gotcha with upgrade steps it remembering to return TRUE - I try to always add type hints cos when someone inevitably copies & pastes them....