Closed heitzjm closed 6 months ago
@heitzjm Can you split this into separate PRs? For example the composer changes seem more complex and will need to be reviewed separately
@mattwire , @eileenmcnaughton I split this PR into three separate PRs : #48 , #49 , #50 .
Stale pull request message
This PR tries to bring some adjustements (at least, I hope so) :
string
type, so I changed it totext
replace
section. Moreover, I tried to switch to Drupal 10, which leads to PHP 8.1 and guzzle v7, and requiring (indirectly) guzzle v6 make installation impossible. Using php-http/discovery without allowing plugin to run seems to provide a convenient way for solving this problem, as geocoder seems only need a PSR18 http client (running the plugin changes composer.json)I didn't manage to run the already included test suite ; however, I was able to run the unit test file (UpgraderTest.php) I added by specifying the test file on phpunit command line.
I did my best for this PR, but I'm still a novice in CiviCRM and in extensions, so please tell me if something is wrong or not appropriate.
Thanks !