eileenmcnaughton / org.wikimedia.geocoder

Geocoder for CiviCRM
Other
6 stars 17 forks source link

[GEOCODER_45] : Pull request : composer, sql, openstreetmap_activation #46

Closed heitzjm closed 6 months ago

heitzjm commented 9 months ago

This PR tries to bring some adjustements (at least, I hope so) :

I didn't manage to run the already included test suite ; however, I was able to run the unit test file (UpgraderTest.php) I added by specifying the test file on phpunit command line.

I did my best for this PR, but I'm still a novice in CiviCRM and in extensions, so please tell me if something is wrong or not appropriate.

Thanks !

mattwire commented 8 months ago

@heitzjm Can you split this into separate PRs? For example the composer changes seem more complex and will need to be reviewed separately

heitzjm commented 8 months ago

@mattwire , @eileenmcnaughton I split this PR into three separate PRs : #48 , #49 , #50 .

github-actions[bot] commented 6 months ago

Stale pull request message