search

eileenmcnaughton / org.wikimedia.relationshipblock

Other
5 stars 11 forks source link

Inline edit too large when contact image #23

Closed martinh-pw closed 4 years ago

martinh-pw commented 5 years ago

A bit of an odd corner case happens when a contact has an image. The clickable area for this block (to activate the inline edit form) becomes too large and encompasses the section above (tags, etc). In our case that means that clicking on the drupal userid next to the contactid became unavailable.

This happens because in the condition above civi adds the float-left class to one of the divs. See here: templates/CRM/Contact/Page/View/Summary.tpl

Not sure if this is the exact right solution, but I was able to fix it by adding class crm-clear to div#crm-relblock-content on line 1 here: templates/CRM/Relationshipblock/Page/Inline/RelationshipBlock.tpl

Tested on 5.16.3/drupal7 and on dmaster at 5.19.alpha1 (contact id 206).

image

eileenmcnaughton commented 5 years ago

@colemanw any thoughts?

colemanw commented 5 years ago

That sounds fine.

colemanw commented 5 years ago

@martinh-pw can you do a PR for that?

martinh-pw commented 5 years ago

you betchaaaa

mattwire commented 4 years ago

@eileenmcnaughton Can this be closed - looks like it was fixed via #24

eileenmcnaughton commented 4 years ago

cool