search

eileenmcnaughton / org.wikimedia.relationshipblock

Other
5 stars 11 forks source link

Block in relationship edit has disappeared in 5.74 #41

Open clarkac1 opened 3 months ago

clarkac1 commented 3 months ago

In 5.74 the custom field set that enables you to specify whether a relationship should appear in the relationship block does not appear any more. I tried disabling, enabling, uninstalling & reinstalling the extension but the the custom field set does not appear when editing a relationship type. It was working fine in 5.72.3. BTW, this is a Drupal 7 system

eileenmcnaughton commented 2 months ago

I have put up a patch against master https://github.com/civicrm/civicrm-core/pull/30417

clarkac1 commented 2 months ago

Thanks, Eileen. When does master get incorporated into the next release? i.e. when would this be in a release? This is a surprisingly useful feature, so thanks for doing it.

eileenmcnaughton commented 2 months ago

@clarkac1 I did do a port to 5.74 & 5.75 so it should be out either in a point version of 5.74 very shortly or in 5.75 next month - if you want to review it that would hurry it up

clarkac1 commented 2 months ago

Will do!

clarkac1 commented 2 months ago

I tested this on dmaster.demo.civicrm.org (at 5.76 alpha) but it's still the 1.7 version, so no dice. Is there a site where I can test this or should I upgrade one of my own test sites, using a nightly download?

eileenmcnaughton commented 2 months ago

@clarkac1 the patch is not yet merged to civicrm core but it is available on the PR test site http://core-30417-4i9ht.test-1.civicrm.org:8001/civicrm/admin/reltype?reset=1

clarkac1 commented 2 months ago

Thanks - I have tested it on this site and it works just fine. I added the block to a contact summary, and added one relationship where it shows and one where it doesn't, which isn't really the point of the test. But the custom part of the relationship type appears, which is the point, so all is well.