search

eiman-kased / starbulls

1 stars 4 forks source link

FIRE: Homepage is broken! #106

Closed billythakidd04 closed 3 years ago

billythakidd04 commented 3 years ago

image

I assume this is from the changes meant for #66 but i think some wires got crossed. We are missing a lot of the home page and what is there is pretty messed up.

We need to clean this up asap. I would consider this top priority. Over all else. Without a decent home page. the rest of the site won't even be looked at.

nburd90 commented 3 years ago

@billythakidd04 I am not seeing the page turn out like this. It shows up fine in my browser, but I did have a thought.

Different people could have their browser zoomed in or out, depending on their preference, and this could lead to discrepancy as to where people are seeing the text show up on the images and carousels.

vricci518 commented 3 years ago

This is definitely a monitor issue. When viewing the home page on my laptop, I'm seeing the Hero text and Carousel Captions. image Viewing the home page on my external monitor at full screen shows the texts falling off the image or partially obstructed. image This looks like a styling issue related to the assigned font sizes. I will be researching solutions, please share any solutions you might find as well.

billythakidd04 commented 3 years ago

I'll continue testing under different settings also.

margeschrec commented 3 years ago

I went ahead and testing some CSS adjustments out targeting the image and carousel inner classes to keep the text inside. I moved the hours of operations onto another row in-between the two carousels to help readability on smaller screens, just a proposal. Maybe in a future ticket we can have the hours of operations exist in the top carousel on large screens, and below on its own row for small screens.

I will create a draft pull request to show you my changes.