Refactor reviewApi.js - Githubissues

eiman-kased / starbulls

1 stars 4 forks source link

Closed billythakidd04 closed 3 years ago

billythakidd04 commented 3 years ago

Dried out the code by moving duplicative functionality into functions
Fix the ajax calls to all follow the same design
left createNewReview() to handle errors internally an remain asynchronous since we are never having to wait for its return.
handled errors and messaging more cleanly
alerting of user to issues handled for more issues also
also cleaned comments and added comments everywhere possible

billythakidd04 commented 3 years ago

We should merge this before #124 as it addresses some of the issue found in that pr

billythakidd04 commented 3 years ago

@nburd90 and @williamrockowl this would be a good pr for both of you to review. It's a good example of js, async, and functions.