search

einaregilsson / Redirector

Browser extension (Firefox, Chrome, Opera, Edge) to redirect urls based on regex patterns, like a client side mod_rewrite.
http://einaregilsson.com/redirector/
MIT License
1.52k stars 156 forks source link

Feature Request: Add compatibility for Firefox Mobile (Android) #29

Open myano opened 9 years ago

myano commented 9 years ago

Could you please add compatibility for Firefox Mobile for Android please?

einaregilsson commented 9 years ago

Sorry, that's probably never gonna happen, unless someone else submits a pull request. I don't use Android or Redirector, and this project is really just in maintenance mode. I'll leave this issue open if someone else wants to tackle it.

myano commented 9 years ago

@einaregilsson Okay, thanks for the heads up, completely understandable. I appreciate the honesty. :-)

If anybody finds this from googling or any other means, please, please, please, comment on this or reach out to me if you figure out how to do this on Android within Firefox. Thanks. :-)

Gitoffthelawn commented 9 years ago

Einar is very willing to have people contribute to the project. I made UI improvements a while back, and it was excellent (and easy) to work with Einar.

einaregilsson commented 9 years ago

No one should work on this without first looking at https://github.com/einaregilsson/Redirector/issues/30 to see where Redirector is going.

KrasnayaPloshchad commented 8 years ago

Current version is available on Firefox for Android, but I don’t know how to open the setting page.

einaregilsson commented 8 years ago

Does Firefox on Android not have toolbar buttons? If it does the Redirector button should be available. Alternatively you can go to resource://redirector-at-einaregilsson-dot-com/redirector.html and bookmark that.

KrasnayaPloshchad commented 8 years ago

Firefox for Android doesn’t support toolbar buttons, and this addon seems not useful even if I opened redirector.html

einaregilsson commented 8 years ago

I've just published 3.0.6 which adds a preferences button, which should work on Android. It's awaiting review right now, should be out in the next couple of days.

KrasnayaPloshchad commented 8 years ago

On Firefox for Android, this addon noticed “Redirector does not work in Private Mode” even if open the setting page in normal mode.

Gitoffthelawn commented 8 years ago

@einaregilsson It looks like Redirector does work in Private Mode in the desktop version of Firefox, but does not work in the Android version of Firefox. Is my understanding correct?

einaregilsson commented 8 years ago

Redirector doesn't work in private mode, I just updated it to show a message on the page instead of showing some angular code. I'm not sure what's going on with Android, I'll try to look into it, but it probably won't be for at least a few weeks.

KrasnayaPloshchad commented 8 years ago

@einaregilsson I think you can try Bluestacks to run Firefox for Andoid if you want to know what's going on with Android.

Gitoffthelawn commented 8 years ago

@einaregilsson wrote "Redirector doesn't work in private mode, I just updated it to show a message on the page instead of showing some angular code. I'm not sure what's going on with Android, I'll try to look into it, but it probably won't be for at least a few weeks."

First, when you say "on the page", to which page are you referring?

Also, I just gave it a try in a Private Window in Firefox 44.0.2 (desktop), and it seems to work. I entered a URL in the urlbar that has a Redirector rule, and it redirected as expected.

einaregilsson commented 8 years ago

That is really weird, because the Redirects page definitely doesn't work in Private mode, that's why I thought the entire addon would be disabled! I need to look into it, and the Android stuff, but I don't have time right now.

Gitoffthelawn commented 8 years ago

@einaregilsson No problem. I just tried loading the Redirector configuration page in Private mode, and I got "Redirector doesn't work in private mode" message. I guess that's the one you just added. I don't know what it did before you added that. Outside of that, Redirector seems to work in Private mode, but I haven't tested it extensively.

No rush from me at all. Look at it when it's fun for you! :-)

KrasnayaPloshchad commented 8 years ago

@einaregilsson I think you can try Bluestacks to run Firefox for Andoid if you want to know what's going on with Android.

You can also try Android-x86 on VMware Player or VBox to run Firefox for Mobile, which has x86 version in their FTP site.

https://ftp.mozilla.org/pub/mobile/

einaregilsson commented 8 years ago

Sorry, still don't have time for this. I'm basically just waiting until WebExtensions is mature enough in Firefox that I can just use the normal Chrome extension in Firefox as well, then the extension should work on Android as well. But anyone is free to investigate this issue further if they're interested.

KrasnayaPloshchad commented 8 years ago

Does Firefox on Android not have toolbar buttons? If it does the Redirector button should be available. Alternatively you can go to resource://redirector-at-einaregilsson-dot-com/redirector.html and bookmark that.

This page does not work since I updated to 3.1.0 in FF for Android 38.0.

KrasnayaPloshchad commented 7 years ago

I found there is a way to find & open the configuration page, input moz-extension://your extension ID/redirector.html in location bar and press Enter would open it. This ID is available at about:config page if you installed this extension in your phone, by inputing extensions.webextensions.uuids option.

einaregilsson commented 7 years ago

Thanks for the workaround :)

KrasnayaPloshchad commented 7 years ago

Firefox Mobile will bring WebEx support in 56.0. https://www.mozilla.org/en-US/firefox/android/56.0beta/releasenotes/

einaregilsson commented 7 years ago

I don't really use Android, but if someone wants to contribute they're more than welcome to, I'm not really working on this extension anymore, but will release new versions if someone contributes a patch.

shirish93 commented 6 years ago

Hey @einaregilsson , I've been playing with making firefox addons a bit, so I can give it a shot!

So I want to get a sense of what the issue here is: Is it "Redirector doesn't work on android", or is it "such and such API doesn't work on android", or something else?

I tried to get it working on my android, and the settings page didn't pop up, so I have a solid sense where to start from! Also, since I have looked at the mdn docs for webextensions to the point my eyes were bleeding, I also have a general sense of the limitations or possible issues in porting this to a working version in android (the android API is a lot limited than general webextension API).

Is there anything else I should know before I begin/have any suggestions so that I may avoid wild goose chases?

Here's what I've prioritized for the moment:

Does this seem like a sensible list to you?

shirish93 commented 6 years ago

Hello,

I have a tentative fix for this issue for upto Firefox 56, and then a different one for Firefox 57+ (android). Would a pull request be worth the effort?

einaregilsson commented 6 years ago

Hi @shirish93 , sorry for the late reply. What is the current Firefox release? Is it worth having special cases to support older releases? I would definitely look at a pull request and merge it in if it was working well.

KrasnayaPloshchad commented 6 years ago

The current Firefox release is 56.0, and the 57.0 release will coming in the next week.

einaregilsson commented 6 years ago

Ok, I'd recommend just targeting 57.

Kusresa commented 6 years ago

@einaregilsson

I am wondering what is the status of Redirector for Android? It seems to install and I can access settings page but I don't know if the redirect functionality is working properly or whether UI is optimized for mobile. @shirish93 are you still planning to improve compatibility for Android?

einaregilsson commented 6 years ago

I honestly have no idea. It's not something that I'm explicitly supporting, but it might work. I'd welcome any pull request to give first class support for it, but don't have time (or interest frankly) to work on it myself.

gkrishnaks commented 6 years ago

@KrasnayaPloshchad, @Kusresa I know it's an old thread. Redirector works fine in Firefox for Android in 59. But yes, the settings page UI the overlay form is very hard to edit in small screen - I suggest writing your rules in Desktop Firefox and export it as JSON and import it in Firefox Android.

KrasnayaPloshchad commented 6 years ago

@gkrishnaks I think the settings page UI can be reconstruct using responsive web design.

gkrishnaks commented 6 years ago

@KrasnayaPloshchad, yes, I'm aware of RWD. I am just saying... As it works just fine in desktop version, we can easily write rules with phsycial keyboard (detailed regex for include pattern, exclude pattern, base64 , mainframe subframe and other advanced settings stuff) there in a Desktop /laptop and export json and import in android firefox version in few minutes.