einari / Machine.Specifications.Core

.NET Core version of Machine.Specifications
MIT License
3 stars 1 forks source link

Ported the Tests, fixed some bugs and re-targeted for .Net Standard 1.5 #9

Closed ivanz closed 8 years ago

ivanz commented 8 years ago

This pull request includes the following:

Are you actively going to maintain this project? If not - are you going to be OK moving it into the https://github.com/machine-visualstudio organization, where I can plug it into CI, automate the NuGet publishing, etc.

I am also keen to engage with whatever is left of the MSpec team to figure out whether we can merge the changes (it's not that many changes really) into the main code and take over the maintenance of that, etc.

einari commented 8 years ago

Hi..
I am actively working on the project - just been having 3 weeks of holiday.. :)

Thanks for the pull request. It looks all good. I would love to get it back into the official repository and contribute their instead of my own version of it. If you need a partner in taking over maintenance of the original repo - let me know, I'd love to take part of that.

Before I merge this PR - the commit that removes the support for VSCode. Any particular reason for taking it out? Great having the full VS support, but for myself I only use VSCode - since I'm on a Mac.

ivanz commented 8 years ago

Please join the discussion and see my last message in the MSpec google group here: https://groups.google.com/forum/#!topic/machine_users/q5T7ENS21CQ

Over the next couple of days I plan on going through and cherry picking changes from my branch into a branch of the original MSpec code and use preprocessor for things not supported in .Net Standard as per this doc.

Essentially I don't want change anything for when targeting .NET, so that we don't introduce any breaking/behavioral/functional changes for existing .NET consumers.

In fact maybe in the first pull request I will just do the project system conversion. I did notice they use some MSbuild tasks for GitVersion and Fody for something as well :8ball:

P.S: The reason why I removed the .vscode folder is because I also use VSCode and my settings were different than yours and I thought maybe the .vscode folder should be a "per user thing" which should be ignored.

einari commented 8 years ago

Great @ivanz ! I'll merge your PR - I'm interested in seeing your .vscode settings, please share. I guess moving forward, we continue in the official repository. I'd love to figure out how we should be dealing with .vscode settings - as it might be painful for anyone coming in to have to set up building and debugging.