einride / aip-go

Go SDK for implementing resource-oriented gRPC APIs.
https://aip.dev
MIT License
165 stars 19 forks source link

AIP-161: Field masks currently do not support proper maps validation #249

Open christian-roggia opened 1 year ago

christian-roggia commented 1 year ago

Field masks may permit the specification of specific fields in a map, if and only if the map's keys are either strings or integers, using the . character for traversal.

Field masks should support string keys that contain characters that are problematic for the field mask syntax, using the backtick character.


  // The name of the book.
  // Format: publishers/{publisher}/books/{book}
  string name = 1;

  // Reviews for the back cover. The key is the author of the review,
  // and the value is the text of the review.
  //
  // Valid field masks: reviews, reviews.smith, reviews.`John Smith`
  map<string, string> reviews = 2;
}```

This is currently not supported by the package: providing a field mask that the specifies reviews.`John Smith` or reviews.smith among the paths will result in a validation error.

github-actions[bot] commented 1 month ago

This issue has been open for 365 days with no activity. Marking as stale.