einride / backstage-go

Backstage SDK for Go
https://backstage.io
MIT License
58 stars 3 forks source link

Question on contributing #18

Closed craigcooper11 closed 1 year ago

craigcooper11 commented 1 year ago

Hello @odsod! I see you are the owner of this repo. I was wondering if you are currently accepting PR for new features? I was looking at adding a new field here, https://pkg.go.dev/go.einride.tech/backstage/catalog#EntityRelation that would expose the target. I.E

        "type": "consumesApi",
        "targetRef": "component:default/artist-lookup",
        "target": {
          "kind": "component",
          "namespace": "default",
          "name": "artist-lookup"
        }
      }
odsod commented 1 year ago

@craigcooper11 Sounds good to me, please fire away a PR and let's have a look at it!

odsod commented 1 year ago

@craigcooper11 Just a quick question - the relation schema doesn't seem to have a target key - if what you're looking for is a parsed version of the entity ref, how about using a separate parser? As much as possible, let's try and stick to the schema!