einride / protoc-gen-go-aip-test

MIT License
8 stars 0 forks source link

Add test for an already deleted resource #238

Closed fredrikaverpil closed 4 months ago

fredrikaverpil commented 4 months ago

I believe this is a missing AIP test. We want already deleted resources (including soft-deleted) return NotFound if another attempt to delete them is made.

From https://google.aip.dev/164#errors:

If the user calling a soft Delete has proper permission, but the requested resource is already deleted, the service must succeed if allow_missing is true, and should error with NOT_FOUND (HTTP 404) if allow_missing is false.

In our case, we don't use allow_missing (can also be implicitly treated as its zero-value of false).