search

einride / protoc-gen-go-aip-test

MIT License
8 stars 0 forks source link

Use optional/required etag, when available, in Delete method tests #239

Closed fredrikaverpil closed 3 weeks ago

fredrikaverpil commented 4 months ago

AIP-135 talks about Protected Delete, which entails requiring etag in the proto.

However, the tests for the Delete method does not take etag into account right now. We aim to fix this and is internally tracked as TRA-1554.

Note: there is a conflicting bug in googleapis/api-linter for this currently: https://github.com/googleapis/api-linter/issues/1395

thall commented 3 weeks ago

@fredrikaverpil can this be closed now since we have tests takes the etag into account? https://github.com/einride/protoc-gen-go-aip-test/blob/master/internal/aiptest/deletion/etag.go