einstein95 / crunchy-xml-decoder

GNU General Public License v2.0
35 stars 14 forks source link

Downloading Error #105

Open insanedude63 opened 7 years ago

insanedude63 commented 7 years ago

This program is constantly improving but I still get odd errors from time to time.

Most recently I have been downloading the series Gintama and found some errors with certain videos.

Links used in these examples http://www.crunchyroll.com/gintama/episode-69-please-help-by-separating-your-trash-510200 http://www.crunchyroll.com/gintama/episode-97-exaggerate-the-tales-of-your-exploits-by-a-third-so-everyone-has-a-good-time-men-have-a-weakness-for-girls-who-sell-flowers-and-work-in-pastry-shops-510256

Episodes 69-80 will not download at all. It crashes the downloader somewhere just as it starts to download. I think these use the older video streaming style, not an m3u8. Booting up...

1/150Traceback (most recent call last): File "C:\crunchy\crunchy-xml-decoder.py", line 369, in makechoise() File "C:\crunchy\crunchy-xml-decoder.py", line 317, in makechoise queueu('.\queue.txt') File "C:\crunchy\crunchy-xml-decoder.py", line 106, in queueu ultimate.ultimate(line.rstrip('\n'), '', '') File "crunchy-xml-decoder\ultimate.py", line 283, in ultimate video_hls(filen, video_input) File "crunchy-xml-decoder\hls.py", line 102, in video_hls fetch_streams(output, video) File "crunchy-xml-decoder\hls.py", line 77, in fetch_streams copy_with_decrypt(raw, output, video.key) File "crunchy-xml-decoder\hls.py", line 64, in copy_with_decrypt aes = AES.new(key.key_value, AES.MODE_CBC, iv.decode('hex')) File "C:\Python27\lib\encodings\hex_codec.py", line 42, in hex_decode output = binascii.a2b_hex(input) TypeError: Non-hexadecimal digit found Press any key to continue . . .

I kept at it bypassing the faulty videos and ran across another, Episode 97, that gives a different error. Video failed to download. Writing error... Traceback (most recent call last): File "C:\crunchy\crunchy-xml-decoder.py", line 369, in makechoise() File "C:\crunchy\crunchy-xml-decoder.py", line 317, in makechoise queueu('.\queue.txt') File "C:\crunchy\crunchy-xml-decoder.py", line 106, in queueu ultimate.ultimate(line.rstrip('\n'), '', '') File "crunchy-xml-decoder\ultimate.py", line 279, in ultimate video() File "crunchy-xml-decoder\ultimate.py", line 61, in video os.remove(title + '.flv"') WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'Gintama Season 1 (Eps 50-99) Episode 97 - "Exaggerate the Tales of Your Exploits by a Third, so Everyone Has a Good Time" - "Men Have a Weakness for Girls Who Sell Flowers and Work in Pastry Shops".flv"' Press any key to continue . . .

This one I think is due to having double quotes in the episode title which causes a naming error later in the code.

No rush in fixing the errors because I have alternate methods to getting these files but just a heads up that they exist.

jaw20 commented 7 years ago

This is actually partially related to #101 . I have seen the first case happen (where it errors with TypeError: Non-hexadecimal digit found ) with certain versions of python newer than 2.7.5 (although it doesn't matter if you downgrade as you will get the error seen in #101 .

nauxai commented 7 years ago

how are you getting these error messages? my window just closes and flash something like this too fast for reading.

the work around on #84 helped, I had to manually go change the files, but I hope I can keep the windows from closing next time there's an error.

insanedude63 commented 7 years ago

how are you getting these error messages? my window just closes and flash something like this too fast for reading.

I dunno, I just use the bat file and run the queue. It spits out the error when it comes across a faulty video link.

the work around on #84 helped, I had to manually go change the files, but I hope I can keep the windows from closing next time there's an error.

I make it a point to update all of my software when encountering an error just to make sure it has not already been fixed. The latest revision on github should contain these fixes already if the error has been addressed.

jsonn commented 7 years ago

The Non-hexadecimal digit found issue should be fixed with the last merge.

jsonn commented 7 years ago

@insanedude63 Explicitly start cmd and run the batch file from that.

nauxai commented 7 years ago

running python crunchy-xml-decoder.py is one of the first things I've tried, along with passing /K to cmd, is it supposed to run everything within the cmd window? because I still get a new window that closes if theres an error.

also the latest version still gives error for this link: http://www.crunchyroll.com/hunter-x-hunter/episode-123-centipede-x-and-x-memory-646091

I don't know if its the same problem since I can't read the full error, but applying the changes in the pull request by @Kamekameha is a work around.