einstein95 / crunchy-xml-decoder

GNU General Public License v2.0
35 stars 14 forks source link

link issue #18

Closed sickness0666 closed 9 years ago

sickness0666 commented 9 years ago

http://www.crunchyroll.com/gintama/episode-269-forget-dates-remember-people-you-can-hide-your-porn-mags-but-you-cant-hide-your-678771

im guessing the issue is related to the *\ in title name that cannot be used in windows file names

einstein95 commented 9 years ago

Why does Gintama hate me ;_; (will fix soon)

sickness0666 commented 9 years ago

ahahaha, ya i know. i only had a couple issues, one was with the *\ in a couple ep names, other was from EXTREMLY long names, which you had fixed, so i got the most recent update. ive had issues sometimes with some other eps of shows with ' in the title when processing, instead of &quote, but i just changed the ultimate.py to replace ' and &quote with nothing

sickness0666 commented 9 years ago

another issue link is: http://www.crunchyroll.com/gintama/episode-11-look-overly-sticky-sweet-dumplings-are-not-real-dumplings-you-idiot-510056

issue is with the comma in the title name, stripping out the comma in ultimate.py fixes the issue

einstein95 commented 9 years ago

Hmm... No issues with commas in titles. Could you give a URL whre you "had issues sometimes with some other eps of shows with ' in the title when processing, instead of "e;"?

On Sat, Jun 6, 2015 at 2:39 PM Jeremy notifications@github.com wrote:

another issue link is:

http://www.crunchyroll.com/gintama/episode-11-look-overly-sticky-sweet-dumplings-are-not-real-dumplings-you-idiot-510056

issue is with the comma in the title name, stripping out the comma in ultimate.py fixes the issue

— Reply to this email directly or view it on GitHub https://github.com/einstein95/crunchy-xml-decoder/issues/18#issuecomment-109506260 .

sickness0666 commented 9 years ago

i believe it was with a couple of episodes in hunter x hunter, they would error out when processing through the mkv merge i believe it was, i had ultimate.py just strip out the ' from the video title and had no issues since then

sickness0666 commented 9 years ago

and that "e; was supposed to be the html code &quote, but i guess the comments auto changed it lol

Zaphain commented 9 years ago

http://www.crunchyroll.com/kill-la-kill/episode-1-if-only-i-had-thorns-like-a-thistle-644301 There's an issue with the ellipsis in the title

Problem with this link too: http://www.crunchyroll.com/naruto/episode-131-the-secrets-of-the-mangeky-sharingan-520266 probably from the 'ō' in the title.

einstein95 commented 9 years ago

Should be properly fixed now.