search

einstein95 / crunchy-xml-decoder

GNU General Public License v2.0
35 stars 14 forks source link

arabic subtitles give english subtitles in anime has arabic subtitles #21

Closed mustafasalah closed 9 years ago

mustafasalah commented 9 years ago

hello,

first thanks for supporting Arabic Subtitles, But when I rip subtitles form anime has Arabic subtitle, it give me english Subtitles :(

And Thank You +1:

einstein95 commented 9 years ago

What video are you trying to download, and can you try with the latest revision?

On Fri, Jun 19, 2015 at 6:20 PM mustafasalah notifications@github.com wrote:

hello,

first thanks for supporting Arabic Subtitles, But when I rip subtitles form anime has Arabic subtitle, it give me english Subtitles :(

And Thank You +1:

— Reply to this email directly or view it on GitHub https://github.com/einstein95/crunchy-xml-decoder/issues/21.

mustafasalah commented 9 years ago

I tried this video : http://www.crunchyroll.com/my-love-story/episode-11-my-ocean-678437 And I Tried with lastet revision and result is same :(

einstein95 commented 9 years ago

Okay, I've pushed one more revision, can you try it now? If it still doesn't work, I'll add some stuff to see what's going wrong.

On Sat, Jun 20, 2015 at 4:01 AM mustafasalah notifications@github.com wrote:

I tried this video : http://www.crunchyroll.com/my-love-story/episode-11-my-ocean-678437 And I Tried with lastet revision and result is same :(

— Reply to this email directly or view it on GitHub https://github.com/einstein95/crunchy-xml-decoder/issues/21#issuecomment-113557069 .

mustafasalah commented 9 years ago

when i rip video and subtitles (using _start.bat) i get Arabic subtitles (thank you veryyyyy much!!) But if I rip Subtitle just from video (using _start_subs-only.bat) I get this message "the video subtitles cannot be found, or are region-locked" or I get English Subtitle .

And Thank you very Much Agin :)

einstein95 commented 9 years ago

Ooh, I think I know what's going wrong. Will fix in a bit.

On Sun, 21 Jun 2015 3:42 am mustafasalah notifications@github.com wrote:

when i rip video and subtitles (using _start.bat) i get Arabic subtitles (thank you veryyyyy much!!) But if I rip Subtitle just from video (using _start_subs-only.bat) I get this message "the video subtitles cannot be found, or are region-locked" .

And Thank you very Much Agin :)

— Reply to this email directly or view it on GitHub https://github.com/einstein95/crunchy-xml-decoder/issues/21#issuecomment-113783533 .

einstein95 commented 9 years ago

Dunno why "a bit" was 10 days, but it's now been fixed in 1a6b3a82fee162bca2b65b2f80f1969c85b833df