search

einstein95 / crunchy-xml-decoder

GNU General Public License v2.0
35 stars 14 forks source link

Some minor changes/updates #84

Closed Kamekameha closed 7 years ago

Kamekameha commented 7 years ago

Commits are kind of self-explanatory.

This makes HLS support slightly unnecessary as it seems that RpcApiVideoEncode_GetStreamInfo always return RTMP info on its response. But let's keep it just for future possible cases.

This should close #82, at least I hope so.

Finally, this should also fix what got reported on https://github.com/einstein95/crunchy-xml-decoder/pull/78#issuecomment-248754827.

Dokman commented 7 years ago

@Kamekameha can you make a season selector for the queue getter? i don't know how to do it :(

Kamekameha commented 7 years ago

No @Dokman, sorry, since there's already this altfuncs.vidurl function doing something similar, so I won't really bother. In fact, I don't even know why we have the recently added autocatch function instead of modifying/improving and using this one, it just adds up more repeated code.

Dokman commented 7 years ago

@Kamekameha so it can be reverted and then make a better queue downloader no?

Kamekameha commented 7 years ago

It could, yeah.

Dokman commented 7 years ago

@Kamekameha how it can be done?

Kamekameha commented 7 years ago

I feel like this is getting off the purpose of this PR. @Dokman, there's essentially two answer to your question, the first is by simply refining the regex patterns used in the function, etc; and the second is to get the desired show's id, list all its available collections (which is what's equivalent to each of the tabs/seasons on the series webpage) and finally retrieve all episodes in a per collection basis. With the current code base, I kinda doubt the second is feasible at all, I've the feeling that it'd need some significant amount of refactoring/more code, so basically the first answer is our way to go.

Kamekameha commented 7 years ago

Yeah, I've honestly been waiting for @einstein95's input on this, whether if it'll get merged or whether it needs something else or whatever. Though at this point I think this has merge conflicts with commits subsequent to this PR so I'm not really sure what to expect.

einstein95 commented 7 years ago

Yeah, I'm happy for this to be merged, just the conflicts need to be resolved.

On Sat, Dec 3, 2016 at 7:16 PM Kamekameha notifications@github.com wrote:

Yeah, I've honestly been waiting for @einstein95 https://github.com/einstein95's input on this, whether if it'll get merged or whether it needs something else or whatever. Though at this point I think this has merge conflicts with commits subsequent to this PR so I'm not really sure what to expect.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/einstein95/crunchy-xml-decoder/pull/84#issuecomment-264620391, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWN9SdH07nseed8p0CWTJvI_obkMbJdks5rEQkygaJpZM4KEI76 .

einstein95 commented 7 years ago

Manually merged