einstein95 / crunchy-xml-decoder

GNU General Public License v2.0
35 stars 14 forks source link

shows only ripping at 480 #89

Open Maksta opened 7 years ago

Maksta commented 7 years ago

Hi,

I don't know if this is a present limitation or not, but some older shows like http://www.crunchyroll.com/food-wars-shokugeki-no-soma/episode-1-an-endless-wasteland-678161 cannot be downloaded as 1080. Here is the message I am seeing capture

Other than this, everything works great!

Also, out of curiosity, was it done on purpose that URL links must not include the resolution identifier, i.e. "?p1080=1" ?

Kamekameha commented 7 years ago

The resolution identifier is only relevant for the loaded page's player, it basically tells the player which options to use in order to retrieve the desired resolution through their Rpc API; the code here interfaces through the API directly so we only need the media's id from the URL (the last 6 digits more specifically, as you might've noticed).

Regarding the issue, that same URL does work fine on my end, the only thing on top of my head is that you're having login issues or you aren't a premium user at all, as 480p is the highest resolution available for guests and free users.

Maksta commented 7 years ago

Thanks for the quick reply really helps clear things up.

As for the download issue, I am logged in successfully as a premium user and was successfully able to download some content at 1080. Does the program remember login info or do we need to login every time, if so where would the user info be stored?

I will try out more test cases to rule out any login issues and see if the problem persists.

Maksta commented 7 years ago

I was able to resolve my 480p download issue. I had the quality setting set to "highest" and despite having premium CR access. It was not downloading the highest quality stream. It would sometimes work and download the 1080p stream, but more often than not it would download the 480p stream.

After I manually set the quality setting to 1080p, I am not consistently downloading at 1080.