search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.44k stars 145 forks source link

🚑 Critical bug in componentWillUnmount that breaks the app #129

Closed a-tokyo closed 6 years ago

a-tokyo commented 6 years ago

Description

When disableImagesLoaded is true, componentWillUnmount throws this.imagesLoadedCancelRef is not a function

How to reproduce

Fix

screen shot 2018-05-29 at 6 58 51 am

PR: https://github.com/eiriklv/react-masonry-component/pull/128

roruva commented 6 years ago

Hi, I have the same issue, what did you do to solve it? thanks in advance.

a-tokyo commented 6 years ago

@roruva I had to not use disableImagesLoaded for now :/

I opened a PR that fixes it, hopefully it gets merged soon 👍

Edit: you can also use this at the meantime https://github.com/A-Tokyo/react-masonry-component

afram commented 6 years ago

6.2.1 should be published. Apologies for the delay and thanks for the contribution