search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.44k stars 145 forks source link

Matches-selector update breaks this #15

Closed thgil closed 8 years ago

thgil commented 8 years ago

You get this error when you load this component now. Uncaught TypeError: elem[matchesMethod] is not a function

I think its because https://github.com/desandro/matches-selector got updated to v2.0.0

kenotron commented 8 years ago

I'm hitting this as well. The idea of taking a github.com/desandro/matches-selector as dependency instead of pegging to a MAJOR version is risky at best. Also, not sure why use so much of your own forks of @desandro 's software?

eiriklv commented 8 years ago

@thgil @kenotron See https://github.com/eiriklv/react-masonry-component/issues/14

afram commented 8 years ago

@thgil @kenotron this should be fixed now - can you please try installing again?

thgil commented 8 years ago

@afram Thanks a lot, it's working again.