search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.43k stars 145 forks source link

Update to React 17 #156

Closed TheOneAndOnlyGarcia closed 3 years ago

TheOneAndOnlyGarcia commented 3 years ago

if possible, it would be nice if the package.json could be updated to react 17.

mgreca commented 3 years ago

I've created a PR for this #157

doverradio commented 3 years ago

@mgreca I see you found no conflicts.

However, I just tried adding this to a project with react@17.0.2

Result: 

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0-0 || ^16.0.0-0" from react-masonry-component@6.2.1
npm ERR! node_modules/react-masonry-component
npm ERR!   react-masonry-component@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Is there any way to solve this error and use this react-masonry-component with react@17.0.2?

mgreca commented 3 years ago

@doverradio the PR #157 solves that issue but is not merged, we need @eiriklv to merge it and release a new version.

afram commented 3 years ago

It's merged and published, though looks like there are quite a few outdated packages. I don't have a lot of time these days sorry, but if someone were to update the dependencies, I'll review and merge.