search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.44k stars 145 forks source link

Unknown prop warning #44

Closed jamieshepherd closed 8 years ago

jamieshepherd commented 8 years ago

Updated React today to be greeted with this warning in the console. Haven't changed anything from my masonry component, still trying to figure out exactly how to prevent it. Only Masonry triggering this warning. My code is standard from README.md.

image

Linked: https://fb.me/react-unknown-prop

jamieshepherd commented 8 years ago 
<Masonry
    className={'my-gallery-class'}
    options={this.masonryOptions}
    disableImagesLoaded={false}>
    { childElements }
</Masonry>
afram commented 8 years ago

Thanks for reporting @jamieshepherd will investigate tonight

afram commented 8 years ago

@jamieshepherd this is happening because those props are being passed down to the div this component creates.

I'll update the code base and will let you know when it's released

empz commented 8 years ago

I was about to post the same issue. The custom props don't have to be passed down to the rendered div.

afram commented 8 years ago

fixed in v4.2.0