search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.44k stars 145 forks source link

typings.d.ts using export as namespace syntax as recommended for exte… #59

Closed cwmoo740 closed 7 years ago

cwmoo740 commented 7 years ago

…rnal modules

https://www.typescriptlang.org/docs/handbook/modules.html

It is recommended for "external modules" e.g. npm installable modules to use this syntax for declaration files.

Also, the current typings file prevents any typescript project from using this repo:

error TS2666: Exports and export assignments are not permitted in module augmentations.

And modules that provide a "typings" field in package.json cannot blacklist an incorrect typings file.

afram commented 7 years ago

Thanks for this, will merge it in now and fix the tests before publishing. Will let you know when it is published.

afram commented 7 years ago

@cwmoo740 @emzero this is done.

v4.3.2