Handle first element removal bug

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry

MIT License

1.44k stars 145 forks source link

Handle first element removal bug #64

Closed yoadsn closed 7 years ago

yoadsn commented 7 years ago

Added tests only pinpoint the problem but many more could be added to cover the different use cases. Logic of diffing is screwed up atm - commented to light up the problematic parts but aside from fixing what is need to overcome this bug did not refactor the entire thing (which should be done when more tests are in place).

This also reverts the diffing algorithm calculation to it's behavior pre v5.0.0

afram commented 7 years ago

I've been on holidays apologies for the delay. Will look at this tonight when I get home.

afram commented 7 years ago

v5.0.1