search

eiriklv / react-masonry-component

A React.js component for using @desandro's Masonry
MIT License
1.44k stars 145 forks source link

React.createClass is deprecated and will be removed in version 16 #74

Closed conghai closed 7 years ago

conghai commented 7 years ago

Warning: MasonryComponent: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.createclass

Please check it.

MrSauceman commented 7 years ago

Same thing here, I'm surprised react throws this warning for an installed dependency...

Fensterbank commented 7 years ago

index.js needs to be rewritten in ES2015 to avoid this warning. In fact this should be pretty easy, the component isn't very complex, but we need to upgrade / change the build tools to make this work with ES2015 and JSX.

afram commented 7 years ago

Should be fixed in v5.0.5

arpecop commented 7 years ago

npm update pix@1.0.0 /Users/rudix/Desktop/arpecop/_apps/pix └── react-masonry-component@5.0.5 wow guys , just wow

afram commented 7 years ago

@arpecop can you please elaborate. Did I break something for you?

arpecop commented 7 years ago

No, actually I am amazed by the efforts you put in something "open source" , this React update is pretty new and "Warnings" are too much to keep count and understand them ... not the case with this module Thanks!

afram commented 7 years ago

That's great to hear, thanks @arpecop! While I've got your attention, did my comment help you with https://github.com/eiriklv/react-masonry-component/issues/65?