Overhaul syntax highlighting

eirikpre / VSCode-SystemVerilog

SystemVerilog support in VS Code

MIT License

128 stars 50 forks source link

Overhaul syntax highlighting #104

Closed jecassis closed 3 years ago

jecassis commented 3 years ago

Replace syntax highlighting with YAML-based version for ease of development
Forked from TextMate Verilog and substantially extended
Coloring follows names of popular VS Code themes such as One Dark Pro
Validate and refine regular expressions using SystemVerilog Tester repository
Fixes #99 and #41

eirikpre commented 3 years ago

Woah, excellent work!

I'm sorry I haven't been able to look at this before, starting process now.

jecassis commented 3 years ago

I have continued making changes in this area as I walk through the issues from the LRM. These have been included in pull request #107. It was becoming difficult to test everything together with many branches. Initially I wanted to keep the changes isolated so that they were simpler to review.

eirikpre commented 3 years ago

After trying your colorization schema, I think it is covering the language very well!

I did some small bugfixes, and reverted back to using the regexp scope for compiler directives on master. I just think it's a nice way to make them stand out.

I'll put up a marketplace release on Monday, so all your good work is live.