search

eirikpre / VSCode-SystemVerilog

SystemVerilog support in VS Code
MIT License
128 stars 50 forks source link

fix: #177: Properly handle Windows paths in Verilator output #178

Closed agg23 closed 2 years ago

agg23 commented 2 years ago

Windows paths were not being handled in Verilator output, preventing the lint results from appearing.

Additionally, the tests were not fully testing the lint output, and did not include Windows path styles on any OS.

joecrop commented 2 years ago

Thanks for fixing this @agg23. It all looks good, just a minor lint violation. Would you mind fixing it? Then I'll merge it.

agg23 commented 2 years ago

Hopefully that fixes it. I'm not sure what's wrong with my setup, but ESLint and Prettier are going nuts on this repo. They're complaining about carriage returns everywhere.

joecrop commented 2 years ago

OK, It's still not happy, let me pull the branch and try it on my computer.

joecrop commented 2 years ago

I feel like there is an issue with the GitHub actions cache or something. It's complaining about a file that has not changed... and now the other tests are failing. I'm not sure what to do to resolve this.

agg23 commented 2 years ago

It's failing on VSCode 1.71.1, which just came out yesterday. Perhaps something else changed?

joecrop commented 2 years ago

It's failing on VSCode 1.71.1, which just came out yesterday. Perhaps something else changed?

Yeah, everything I am reading is telling me that the npm needs to be cleaned and reinstalled... I guess I'll try adding it to the pipeline at the expense of a slower job...

joecrop commented 2 years ago

@agg23 can you please rebase master? I have the pipeline fixed now.