DefinitionProvider bugfixes

[LarsAur]

Main Changes

These changes attempt to fix some bugs related to the DefinitionProvider not being able to find some parameters and ports:

• Fix usage of results.concat for ports and ensure all symbol lookups resolve before returning the results.
• Make the parameter name match correctly. In some cases the datatype was matched as the name. Also enable more datatypes for parameters e.g. int unsigned.
• Fix definition lookup of symbols in packages
• Add tests

See extended commit messages for more details.

Results after changes

Definition of port:

Definition of typed parameter:

Definition of parameter defined in package:

[joecrop]

This is brilliant, thanks @LarsAur. I will start reviewing this now.

[LarsAur]

I see that the tests failed while downloading vscode for windows. I also encountered this problem while testing the changes. Seems like the link used does not work any more (https://update.code.visualstudio.com/1.85.1/win32-archive/stable) I had success adding the following changes to runTest.ts.

In the imports

import { runTests, downloadAndUnzipVSCode } from '@vscode/test-electron';

In main() after setting workspacePath

const vscodeExecutablePath = await downloadAndUnzipVSCode('stable', 'win32-x64-archive');

// Download VS Code, unzip it and run the integration test
await runTests({
    extensionDevelopmentPath,
    extensionTestsPath,
    vscodeExecutablePath,
    launchArgs: [workspacePath, '--disable-workspace-trust', '--disable-extensions']
});

Edit: If you want, I can create a separate pull request for these changes.

[joecrop]

Yeah, I saw the problem and just fixed it. Can you please rebase/merge upstream/master?

[joecrop]

Tests are passing, Awesome!