search

eirikpre / VSCode-SystemVerilog

SystemVerilog support in VS Code
MIT License
126 stars 50 forks source link

Revert "Fixed autoinstantiation tripping on brackets and unpacked dimensions" #212

Closed joecrop closed 8 months ago

joecrop commented 8 months ago

Reverts eirikpre/VSCode-SystemVerilog#198

@richzwart the tests fail because comments are clobbered. For example:

 adder u_adder (
         .clk      (clk),
         .reset    (reset),
         .a        (a),
+        //keepthissinglecomment
-        // keep this single comment
         .b        (b),
+        /*multilinecommentshould
+      bekept*/
-        /* multiline comment should
-        be kept*/
         .valid    (valid),
         .c        (c)
       );

I'm going to revert this back for now. Please do the following:

  1. rebase/merge the latest master so that tests will run in your branch
  2. Help me understand why comments are being clobered, I'm happy to look at it with it to resolve this.

Thanks,

Joe

richzwart commented 8 months ago

Hey Joe, Ah I hadn't noticed that. I have a fix pushed to my fork, but I'm having issues verifying them with the tests by running the "Extension Tests". It seems to be pulling the latest release of your plugin when running. Is there an easy way for me to fix this? I apologize if I missed something - I'm still rather new to this development environment. Thanks, -Rich

On Fri, Jan 5, 2024 at 7:16 PM Joe Crop @.***> wrote:

Reverts #198 https://github.com/eirikpre/VSCode-SystemVerilog/pull/198

@richzwart https://github.com/richzwart the tests fail because comments are clobbered. For example:

adder u_adder ( .clk (clk), .reset (reset), .a (a),+ //keepthissinglecomment- // keep this single comment .b (b),+ /multilinecommentshould+ bekept/- / multiline comment should- be kept/ .valid (valid), .c (c) );

I'm going to revert this back for now. Please do the following:

  1. rebase/merge the latest master so that tests will run in your branch
  2. Help me understand why comments are being clobered, I'm happy to look at it with it to resolve this.

Thanks,

Joe

You can view, comment on, or merge this pull request online at:

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212 Commit Summary

File Changes

(4 files https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files )

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/eirikpre/VSCode-SystemVerilog/pull/212, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBWRTJVIMP536YS2LF7GOG3YNCJUDAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DQMRTGE2TCMI . You are receiving this because you were mentioned.Message ID: @.***>

joecrop commented 8 months ago

Can you try running "npm run test"? If that does the work you can submit a draft pull request and i can tell it to run the test in github actions. Just make sure you merge/rebase master first.

Joe

On Fri, Jan 5, 2024 at 7:01 PM richzwart @.***> wrote:

Hey Joe, Ah I hadn't noticed that. I have a fix pushed to my fork, but I'm having issues verifying them with the tests by running the "Extension Tests". It seems to be pulling the latest release of your plugin when running. Is there an easy way for me to fix this? I apologize if I missed something - I'm still rather new to this development environment. Thanks, -Rich

On Fri, Jan 5, 2024 at 7:16 PM Joe Crop @.***> wrote:

Reverts #198 https://github.com/eirikpre/VSCode-SystemVerilog/pull/198

@richzwart https://github.com/richzwart the tests fail because comments are clobbered. For example:

adder u_adder ( .clk (clk), .reset (reset), .a (a),+ //keepthissinglecomment- // keep this single comment .b (b),+ /multilinecommentshould+ bekept/- / multiline comment should- be kept/ .valid (valid), .c (c) );

I'm going to revert this back for now. Please do the following:

  1. rebase/merge the latest master so that tests will run in your branch
  2. Help me understand why comments are being clobered, I'm happy to look at it with it to resolve this.

Thanks,

Joe

You can view, comment on, or merge this pull request online at:

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212 Commit Summary

Revert "Fixed autoinstantiation tripping on brackets and unpacked dimensions"

File Changes

(4 files < https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files> )

(63)

(40)

(56)

(30)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/eirikpre/VSCode-SystemVerilog/pull/212, or unsubscribe < https://github.com/notifications/unsubscribe-auth/BBWRTJVIMP536YS2LF7GOG3YNCJUDAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DQMRTGE2TCMI>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/eirikpre/VSCode-SystemVerilog/pull/212#issuecomment-1879512452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW66QPPUKLPWKEEN6FMPLTYNC47PAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGUYTENBVGI . You are receiving this because you modified the open/close state.Message ID: @.***>

richzwart commented 8 months ago

Yeah the tests still seem to target the original plugin and not my fork. I've created a new pull request. Let me know if there's anything else I can do.

Rich

On Sat, Jan 6, 2024 at 4:20 PM Joe Crop @.***> wrote:

Can you try running "npm run test"? If that does the work you can submit a draft pull request and i can tell it to run the test in github actions. Just make sure you merge/rebase master first.

Joe

On Fri, Jan 5, 2024 at 7:01 PM richzwart @.***> wrote:

Hey Joe, Ah I hadn't noticed that. I have a fix pushed to my fork, but I'm having issues verifying them with the tests by running the "Extension Tests". It seems to be pulling the latest release of your plugin when running. Is there an easy way for me to fix this? I apologize if I missed something

I'm still rather new to this development environment. Thanks, -Rich

On Fri, Jan 5, 2024 at 7:16 PM Joe Crop @.***> wrote:

Reverts #198 < https://github.com/eirikpre/VSCode-SystemVerilog/pull/198>

@richzwart https://github.com/richzwart the tests fail because comments are clobbered. For example:

adder u_adder ( .clk (clk), .reset (reset), .a (a),+ //keepthissinglecomment- // keep this single comment .b (b),+ /multilinecommentshould+ bekept/- / multiline comment should- be kept/ .valid (valid), .c (c) );

I'm going to revert this back for now. Please do the following:

  1. rebase/merge the latest master so that tests will run in your branch
  2. Help me understand why comments are being clobered, I'm happy to look at it with it to resolve this.

Thanks,

Joe

You can view, comment on, or merge this pull request online at:

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212 Commit Summary

  • deab5a9 <

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/commits/deab5a9fe51d6db9e40bafc4cf0e00f3a5104c63>

Revert "Fixed autoinstantiation tripping on brackets and unpacked dimensions"

File Changes

(4 files < https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files> )

  • M src/providers/ModuleInstantiator.ts <

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files#diff-b28a26605681f959b2402f31bdcccbef9b5aed8c6d85fdfffabff454b9e4502a>

(63)

  • M src/test/ModuleInstantiator.test.ts <

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files#diff-9c6b4cb2f042ec38cc3a1b41da2570f35b000ef8662ef135edda8abea3661d2b>

(40)

  • M src/test/test-files/ModuleInstantiator.test.1.v <

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files#diff-4e6bef61f436724efc2c48c1a50796fc3f370ea0e2afe2ad514f98df025ea847>

(56)

  • M src/test/test-files/ModuleInstantiator.test.2.v <

https://github.com/eirikpre/VSCode-SystemVerilog/pull/212/files#diff-91651dc92071bbd6869c886d2e7b4611c988abf42c9eee19e21168b53699dc4d>

(30)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/eirikpre/VSCode-SystemVerilog/pull/212, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/BBWRTJVIMP536YS2LF7GOG3YNCJUDAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DQMRTGE2TCMI>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/eirikpre/VSCode-SystemVerilog/pull/212#issuecomment-1879512452>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAW66QPPUKLPWKEEN6FMPLTYNC47PAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGUYTENBVGI>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/eirikpre/VSCode-SystemVerilog/pull/212#issuecomment-1879832828, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBWRTJSK7IA3RB7ANGFJ6EDYNG53JAVCNFSM6AAAAABBPDX2KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZHAZTEOBSHA . You are receiving this because you were mentioned.Message ID: @.***>