eirikpre / VSCode-SystemVerilog

SystemVerilog support in VS Code
MIT License
128 stars 50 forks source link

'Go To Definition' Fails Across Files With Specific Multi-Line Comment #76

Closed onesmallskipforman closed 4 years ago

onesmallskipforman commented 4 years ago

The 'Go To Definition' feature displays "No definition found for ''" whenever target_module is in another file and target_module is preceded in the file by a multi-line comment that meets all of the following criteria:

Examples of comments that cause the error:

/*
module abc
*/

 /*
               module 123
 */

/* dog

      module
cat */

Examples of comments that do not cause the error:

/*module abc
*/

/*
moduleabc
*/

/*

            text module 123
*/

/*
module (  123
*/

/*
Module www
*/

/* dog
     module
*/
eirikpre commented 4 years ago

Interesting case, will have a look into it when there is some time :)

Good job on describing the issue including reproduce cases!

eirikpre commented 4 years ago

I think this is fixed now with the updates to the definitionProvider, I did not encounter any issues while testing with mentioned commit. Reopen if the issue still persist.