eirproject / eir

Erlang ecosystem common IR
Apache License 2.0
250 stars 8 forks source link

Map BinaryOp::Or and And to matching erlang word name, not symbolic name #26

Closed KronicDeth closed 4 years ago

KronicDeth commented 4 years ago

While writing integration tests for liblumen_otp, I was having errors that and mapped to an unknown _erlang:&/2 and or mapped to an unknown _erlang:|/2. Checking that I didn't miss & or | in erlang, I tried to TAB completing them with erlang. in iex and couldn't find them while I can find the send alias !. Going further, I tried apply(:erlang, :&, [true, true]) and apply(:erlang, :|, [true, true]) and they both raised UndefinedFunctionError, while :and and :or work as expected. Did I miss something @hansihe?

Changelog

Bug Fixes

hansihe commented 4 years ago

Yep, this is my bad. Thanks for the PR!