search

eirshy / Eirshy.DSP

2 stars 2 forks source link

[Veinity] Update 0.10.29.22010 error #13

Closed PiggyWhiskey closed 5 months ago

PiggyWhiskey commented 6 months ago

Latest update (0.10.29.22010) has broken Veinity All miners are 'paused' not actually mining

image

xe7485 commented 5 months ago

Same thing here.

PiggyWhiskey commented 5 months ago

Seems to be related to the new 'Alerts' system, the voice-over telling the player that a vein is empty

xe7485 commented 5 months ago

This seems to fix it factory.NotifyVeinExhausted((int)vtarg.type, vtarg.pos );

eirshy commented 5 months ago

Yeah the new alerts broke it, they added arguments to that fn. Annoying that they didn't make the vein type take in the enum, but what can you do. I didn't look to see if I already had a ref to vein so my update needlessly grabs another, but otherwise it's fixed. Already switched it to using vtarg in the codebase, so whenever the next update to Veinity happens, it'll switch. Perf impact should be functionally nil anyways.

PiggyWhiskey commented 5 months ago

Got another error when mineral is depleted. image

Tested with an auto-save without Veinity and no error.

PiggyWhiskey commented 5 months ago

^Resolved 0.2.6