search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.21k stars 867 forks source link

add condition to arm arch with non v7 version. #1018

Closed jackiehxm0228 closed 2 years ago

jackiehxm0228 commented 2 years ago

Such condition exist in most recent Raspberry Pi OS version 5.10.63-v8+

Summary

Tests and Documentation

jackiehxm0228 commented 2 years ago

pi@raspberrypi:~ $ uname -a Linux raspberrypi 5.10.63-v8+ #1496 SMP PREEMPT Wed Dec 1 15:59:46 GMT 2021 aarch64 GNU/Linux pi@raspberrypi:~ $ java -jar test.jar arch: arm version: 5.10.63-v8+

jackiehxm0228 commented 2 years ago

Any updates on this pull request?

jackiehxm0228 commented 2 years ago

If you don't like what I have changed, please remove linux x86 version cause it does not exist anymore. Nodejs download directory: https://nodejs.org/dist/v16.14.2/ Maven build log: [INFO] Downloading https://nodejs.org/dist/v16.14.2/node-v16.14.2-linux-x86.tar.gz to /var/lib/jenkins/.m2/repository/com/github/eirslett/node/16.14.2/node-16.14.2-linux-x86.tar.gz

eirslett commented 2 years ago

Oh sorry, I completely missed this! Looks good to me, I guess.

jackiehxm0228 commented 2 years ago

Thank you Sir! Have a great day!