Fix issues for pnpm - Githubissues

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.

Apache License 2.0

4.21k stars 867 forks source link

Fix issues for pnpm #1037

Closed luangong closed 1 year ago

luangong commented 2 years ago

Summary

This commit fixes the following issues for pnpm:

Comment mismatch.
pnpm is never "provided" by Node.js so <pnpmVersion> is required.
Java class name CamelCase: PNPMInstaller -> PnpmInstaller.

Tests and Documentation

Although pnpm support was added in https://github.com/eirslett/frontend-maven-plugin/pull/927, documentation is lacking in README.md and the project wiki. I will add documentation in a follow-up pull request.

luangong commented 1 year ago

@eirslett Can you please take a look? Thanks!

luangong commented 1 year ago

@eirslett Please take a look. Thanks!

eirslett commented 1 year ago

LGTM!