search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.21k stars 867 forks source link

isYarnrcYamlFilePresent bug #1038

Open SurfaceS opened 2 years ago

SurfaceS commented 2 years ago

Do you want to request a feature or report a bug? Report a bug

What is the current behavior? On com.github.eirslett.maven.plugins.frontend.mojo.InstallNodeAndYarnMojo

isYarnrcYamlFilePresent() doesn't take in account the installDirectory and workingDirectory from the AbstractFrontendMojo

If the current behavior is a bug, please provide the steps to reproduce. Use the `

installdir 
                <workingDirectory>workingdir</workingDirectory>
            </configuration>`

What is the expected behavior? isYarnrcYamlFilePresent() should check if the YARNRC_YAML_FILE_NAME exists under the working directory mentionned in configuration.workingDirectory.

Please mention your frontend-maven-plugin and operating system version. frontend-maven-plugin : 1.12.1 operating system version : Windows 11