eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.2k stars 867 forks source link

Plugin Validation Issue on Maven 3.9.2 #1085

Closed henderea closed 1 year ago

henderea commented 1 year ago

Do you want to request a feature or report a bug? Bug

What is the current behavior? With the latest maven 3.9.2, I see a plugin validation issue:

[WARNING]  * com.github.eirslett:frontend-maven-plugin:1.12.1
...
[WARNING]   Plugin issue(s):
[WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-plugin-api:3.6.0, org.apache.maven:maven-model:3.6.0, org.apache.maven:maven-artifact:3.6.0]

If the current behavior is a bug, please provide the steps to reproduce. Run a maven build with -Dmaven.plugin.validation=verbose to see the full details, though you'll get a basic notice with any maven build on maven 3.9.2.

What is the expected behavior? No warning.

Please mention your frontend-maven-plugin and operating system version. frontend-maven-plugin: 1.12.1 (as seen in maven build output above) OS: macOS 12.6.5 Maven: 3.9.2 Java: 11.0.16

xak2000 commented 1 year ago

As a note to why this is happening, see Maven 3.9.2 Release Notes - the part about "Plugin validation warnings change".

Basically, they are preparing to upcoming Maven 4, so these warnings should be fixed to make plugin compatible with Maven 4.

eirslett commented 1 year ago

I think this should be fixed with the latest 1.13.1 release.

xak2000 commented 1 year ago

@eirslett I tried 1.13.1 and warnings are not completely gone.

[WARNING]
[WARNING] Plugin validation issues were detected in 1 plugin(s)
[WARNING]
[WARNING]  * com.github.eirslett:frontend-maven-plugin:1.13.1
...
[WARNING]   Plugin issue(s):
[WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-artifact:3.6.0]

You can check it yourself by running:

mvnw compile -Dmaven.plugin.validation=VERBOSE

on any project, that uses Maven Wrapper 3.9.2 and frontend-maven-plugin 1.13.1.

eirslett commented 1 year ago

oh :-( how about 1.13.2?

xak2000 commented 1 year ago

Tried 1.13.2 - works without warnings! 👍