search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.2k stars 868 forks source link

Basic bun integration #1108

Closed deemkeen closed 7 months ago

deemkeen commented 9 months ago

Summary

Basic bun integration as requested in #1106 Bun still doesn't work with windows, so i've tried to skip the windows integration tests, maybe there is a better way to do it

eirslett commented 8 months ago

I'm a bit worried about scope creep for the frontend-maven-plugin. Would it make sense to make something separate, like bun-maven-plugin?

deemkeen commented 8 months ago

I'm a bit worried about scope creep for the frontend-maven-plugin. Would it make sense to make something separate, like bun-maven-plugin?

Maybe it could be an option, on the other hand this plugin is quite universal, it also supports yarn, so i've thought it would be a good idea to add this feature also

deemkeen commented 7 months ago

@eirslett So as i understand, it's an organizational problem to integrate this because it's difficult to maintain so many technologies? Or is there something else to consider? Should this PR be closed?

eirslett commented 7 months ago

Yes it's mostly organizational. More features keep getting requested and added, but there's limited time for maintenance, bug fixes etc. But I triggered the test suite now. I suppose we can merge the bun stuff, it's a promising runtime!

eirslett commented 7 months ago

Looks like the MacOS build is failing on bun install for some reason...

deemkeen commented 7 months ago

Looks like the MacOS build is failing on bun install for some reason...

strange..maybe some github hickup, my pipeline ist green:

https://github.com/deemkeen/frontend-maven-plugin/actions/runs/7047737618

maybe we could rerun it?

eirslett commented 7 months ago

It was a hiccup!

deemkeen commented 7 months ago

@eirslett great, thanks!

eirslett commented 3 months ago

@deemkeen could you please have a look at updating support here, so Bun also can be used on Windows?

deemkeen commented 3 months ago

@eirslett yeah sure, I'll take a look at it this weekend!

deemkeen commented 2 months ago

I'm getting strange crashes, while trying to run the tests with the windows runner. Does anyone have any ideas?

[INFO] [DEBUG] Executing command line [D:\a\frontend-maven-plugin\frontend-maven-plugin\frontend-maven-plugin\target\it\bun-integration\target\bun, install] [INFO] [INFO] [INFO] [INFO] Panic: start index is larger than end index [INFO] [INFO] [INFO] [INFO] bun has crashed :'( [INFO] [INFO] [INFO] [INFO] ----- bun meta ----- [INFO] [INFO] Bun v1.1.2 (c8d072c2) Windows x64 [INFO] [INFO] Unknown: [INFO] [INFO] Elapsed: 0ms | User: 0ms | Sys: 0ms [INFO] [INFO] RSS: 16.79MB | Peak: 16.79MB | Commit: 62.39MB | Faults: 4255 [INFO] [INFO] ----- bun meta ----- [INFO] [INFO] [INFO] [INFO] 0 00007FF74836E048 [INFO] [INFO] 1 ??? [INFO] [INFO] 2 ??? [INFO] [INFO] 3 ??? [INFO] [INFO] 4 ??? [INFO] [INFO] 5 ??? [INFO] [INFO] 6 ??? [INFO] [INFO] [INFO] [INFO] Search GitHub issues https://bun.sh/issues or join in #windows channel in https://bun.sh/discord [INFO] [INFO] [INFO] [INFO] thread 3632 panic: start index is larger than end index [INFO] [INFO] ???:?:?: 0x7ff746fae7de in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ff746cd1603 in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ff74986e033 in ??? (bun) [INFO] [INFO] ???:?:?: 0x7ffe38334caf in ??? (KERNEL32.DLL) [INFO] [INFO] ???:?:?: 0x7ffe3863e8aa in ??? (ntdll.dll) [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [INFO] BUILD FAILURE

Is it possible, that the windows support is still experimental?

eirslett commented 1 month ago

@deemkeen Not sure! Maybe they have ironed out the issues by now? @giverly-devops if you're able to, you could take a stab at it! (See #1146)