search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.2k stars 868 forks source link

Use a script to proxy PNPM executable on Windows #1116

Closed jonkoops closed 8 months ago

jonkoops commented 8 months ago

Since Windows does not support symbolic links (or at least not consistently), the choice was made not to support the PNPM executable under Windows. This PR adds support for running the PNPM executable by adding a script under the same name in the installation directory, and proxy any commands sent to it to the PNPM executable.

This also allow the removal of some of the testing profiles that were previously added as the tests would not pass under Windows. And also removes the legacy linking code that was copied from the NPM version that never worked.

Closes #1115

jonkoops commented 8 months ago

Looks like the tests on Windows are flaking out on something unrelated to the changes in this PR? Perhaps a re-run will pass them.

eirslett commented 8 months ago

Looks like it works. Thanks!

jonkoops commented 8 months ago

Thanks for getting to this so quick @eirslett, much appreciated.

eirslett commented 8 months ago

Could you please help update the changelog as well? I think this will be released as a patch version.

jonkoops commented 8 months ago

Sure, opened a PR under #1117