search

eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.2k stars 868 forks source link

[Feature] execution enable option #1131

Closed long76 closed 5 months ago

long76 commented 5 months ago

Do you want to request a feature or report a bug?

feature

What is the current behavior?

for add or disable execution from parent pom i need dubplicate plugin section with executions but without goals

What is the expected behavior?

enable option default true

in parent pom.xml

<execution>
    <id>install node and npm</id>
    <goals>
        <goal>install-node-and-npm</goal>
    </goals>
</execution>

in child pom.xml

<properties>
    <enableInstall>true</enableInstall>
</properties>

<execution>
    <enable>${enableInstall}</enable>
    <id>install node and npm</id>
    <goals>
        <goal>install-node-and-npm</goal>
    </goals>
</execution>

now we can disable execution by property -DenableInstall=false

Please mention your frontend-maven-plugin and operating system version. Version 1.15.0, Kubuntu 22.04

long76 commented 5 months ago

my fault, just use ${enableInstall} in skip in configuration execution

<execution>
    <id>install node and npm</id>
    <goals>
        <goal>install-node-and-npm</goal>
    </goals>
    <configuration>
        <skip>${enableInstall}</skip>
    </configuration>
</execution>