eirslett / frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.
Apache License 2.0
4.26k stars 872 forks source link

fix: yarn berry detection in case working directory is changed #1143

Closed holomekc closed 6 months ago

holomekc commented 6 months ago

Summary In case the workingDirectory option is used the detection of yarn berry does not work properly: image

To fix that the workingDirectory needs to be included for the .yarnrc.yml file detection

As a workaround it is possible to add an empty .yarnrc.yml file into the module root directory. image

Furthermore, I forwarded the is berry check to the runner, so that additional arguments are not set, which are not supported by yarn berry.

Tests and Documentation I updated the workflows, because they complained because of outdated and not supported node versions and updated the java version, because the mac os run complained that Java 8 is not supported anymore.

Furthermore, I added a test for yarn berry.

eirslett commented 6 months ago

Thanks a lot!